Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The reader’s Rotate command changes the view of the whole document. Users need to turn selected pages permanently in a saved PDF.
Change
Rotate one or more pages left or right from Organize pages or the thumbnail context menu. The thumbnails show the proposed orientation, Undo restores it, and Save writes a separate PDF. The organizer supports a one-page document. Saved version history records which pages were rotated.
Issue or approval
Second part of #69, after deletion in #85. The base branch points to the reviewed deletion commit. Retarget to main once deletion lands.
How I checked it
On macOS, the unit tests, production build with type checking, and full hidden smoke suite passed. The smoke test selects two pages, rotates them, undoes a second rotation, saves a reordered copy, and reads the actual rotations and text back from the PDF. It captures the sidebar before and after at release/smoke/organizer-before-rotation.png and release/smoke/organizer-after-rotation.png.
Implemented with GPT-6 in Codex.